Consider credentials mode when calling `CalculateStorageAccessStatus` Storage access status should not be calculated when the request should not include credentials. Storage access headers require requests to be cross-site and and it's specifically designed to request credentials. The `CHECK_EQ` in net/url_request/url_request.cc is removed because now `ShouldSetLoadWithStorageAccess` might calculate the status when called through `BuildResponseHead` inside of `URLLoader::OnReceivedRedirect`. In this case, `is_redirecting_` is set before, while `deferred_redirect_info_` is set after `OnReceivedRedirect`. We could pass down `redirect_info` through `BuildResponseHead` and `ShouldSetLoadWithStorageAccess`, or move `ShouldSetLoadWithStorageAccess` out of `BuildResponseHead` and just call it once inside of `URLLoader::OnResponseStarted`. The former would require piping an argument through multiple hops for no good reason (we don't need the response's `load_with_storage_access` before building the response, using the final URL), while the latter would break the setting of this single variable out of where the rest of the response is built. Bug: 382291442 Change-Id: Ie73585157533906a3d908dbb30856a1278e9dc1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357749 Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Sandor «Alex» Major <sandormajor@chromium.org> Cr-Commit-Position: refs/heads/main@{#1437900}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.