Consider credentials mode when calling `CalculateStorageAccessStatus`

Storage access status should not be calculated when the request
should not include credentials. Storage access headers require requests
to be cross-site and and it's specifically designed to request
credentials.

The `CHECK_EQ` in net/url_request/url_request.cc is removed because
now `ShouldSetLoadWithStorageAccess` might calculate the status when
called through `BuildResponseHead` inside of
`URLLoader::OnReceivedRedirect`. In this case, `is_redirecting_` is set
before, while `deferred_redirect_info_` is set after
`OnReceivedRedirect`.
We could pass down `redirect_info` through `BuildResponseHead` and
`ShouldSetLoadWithStorageAccess`, or move
`ShouldSetLoadWithStorageAccess` out of `BuildResponseHead` and just
call it once inside of `URLLoader::OnResponseStarted`. The former would
require piping an argument through multiple hops for no good reason (we
don't need the response's `load_with_storage_access` before building the
response, using the final URL), while the latter would break the setting
of this single variable out of where the rest of the response is built.

Bug: 382291442
Change-Id: Ie73585157533906a3d908dbb30856a1278e9dc1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357749
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Sandor «Alex» Major <sandormajor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437900}
7 files changed
tree: 4d583999e90193cb0050618e77b675a7bd7ae814
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.