commit 4ab85f6b2f53a5b2fcfb1b4e796f06cf64bd5e74
author Dana Fried <dfried@chromium.org> Wed Nov 13 19:12:14 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 13 19:12:14 2024
tree 8c972cac95d4f2c1c499ee0813abdd7d9fc48fb5
parent 936ba32422c40d955ab2e1f77a41eea870e1170c

Reland "[User Education] Improve testing utils for edge case."

This reverts commit 833e548498de91811710fe5cb73a4c515f687dc9.

Reason for revert: Fix broken tests. Mock method parameters were
underspecified which led to an expectation being saturated by a
different, irrelevant call that should have returned a default value.

Original change's description:
> Revert "[User Education] Improve testing utils for edge case."
>
> This reverts commit 4719c3f2d214d7205b958fd32b7ba7d4570eb952.
>
> Reason for revert: test failed at
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-blink-web-tests-force-accessibility-rel/31474/test-results?sortby=&groupby=
>
> Original change's description:
> > [User Education] Improve testing utils for edge case.
> >
> > WaitForPromo() and CheckPromoIsActive() previously had issues if the
> > promo was shown anywhere but the current context.
> >
> > Now, if InAnyContext(...) is specified, they will function as expected.
> > That is to say, if you do:
> >
> >   InAnyContext(CheckPromoIsActive(kMyPromoFeature))
> >
> > It will succeed if the IPH for kMyPromoFeature is active in any window,
> > even if the help bubble appears in a *different* window than the one
> > the IPH was triggered from, and only fail if the promo is not active
> > anywhere.
> >
> > Tests have been added for the new functionality.
> >
> > Bug: 378691113
> > Change-Id: Id4eecf1857fe0de4ec59d05b23bde155cd894e6f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6011507
> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
> > Commit-Queue: Dana Fried <dfried@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1382032}
>
> Bug: 378691113
> Change-Id: Ic5c2da129913467e52c42580d03576e739f0c9ef
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013930
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1382144}

Bug: 378691113
Change-Id: Id499d4ee06afdd69721cc9b14d0ac831d97abcd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019204
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382497}