commit | 4af865793a852fcc7a53826514c520995fe6a1be | [log] [tgz] |
---|---|---|
author | Aaron Leventhal <aleventhal@google.com> | Fri Mar 07 20:39:30 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 07 20:39:30 2025 |
tree | 070c7fc6161cd54e46e41e05abefc595f3111b17 | |
parent | a1c31038183b110868daef6f5d78eb43cd5bf601 [diff] |
[A11yPerformance] Rename AXMode::kScreenReader to kExtendedProperties The new name is much more descriptive of what the mode actually is, since many non-screen readers can also turn this mode on. In addition, having it be called screen reader mode is confusing since we do now have actual screen reader detection. In fact, working on this makes it clear there are current features that actually think they're switching behavior based on the presence of a screen reader, but are really getting a signal if a utility or OS feature was using a11y APIs. The percentage of users with the misnamed kScreenReader mode was over 10% on some platforms! Bug 401443089 has been filed to audit all the call sites that used AXMode::kScreenReader and use actual screen reader detection (see CL:6336045 for an example of how to do that). This is a foundational piece for separating out two different concepts in BrowserAccessibility related to whether a screen reader is present, so that we can carefully use the right signal for turning off ProgressiveAccessibility/AutoDisable when a screen reader is present. The current kScreenReader mode is a misnomer. See decision doc: https://docs.google.com/document/d/1OJC1PWUjOtacjfwDj-OciPYrOez6DM5x4AoA_gNsAKg/edit Bug: 401232343 Change-Id: Ic92e6f34825168429c6864380386e8e825476c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6331102 Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Jihad Hanna <jihadghanna@google.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Mark Schillaci <mschillaci@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Andy Phan <andyphan@chromium.org> Reviewed-by: Abigail Klein <abigailbklein@google.com> Reviewed-by: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/main@{#1429679}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.