Google Git
Sign in
chromium / chromium / src / 4b1bf2dbc5a08c75804faf8cfdc01714ac9952b2
commit4b1bf2dbc5a08c75804faf8cfdc01714ac9952b2[log] [tgz]
authorCheick Cisse <cheickcisse@google.com>Tue May 06 15:59:36 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 06 15:59:36 2025
tree0a2054cf0195206411007217027f19089945c01e
parent68ff23353bb2e6bf793a8d17b0f9f3e05c778791 [diff]
[iOS][SigninPromo] Fix sign-in fullscreen promo crash with promo manager

This CL updates the SigninFullscreenPromoSceneAgent to observe user
sign-in changes. If the sign-in promo has been registered with the promo
manager but not yet displayed, and the user signs in and either opts into
history sync or declined it multiple times, the promo will be
deregistered from the promo manager.

In addition, this CL ensures that if the fullscreen signin promo is
triggered when the user is already signed in and has either opted into
history sync or has declined it multiple times, it will not result in a
crash (presenting a nil navigation controller). Instead, it will
terminate gracefully.

Bug: 414711997
Change-Id: I995a66393a7a11fd3dec4ad7ad6a61a53e606638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509406
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Cheick Cisse <cheickcisse@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1456386}
10 files changed
tree: 0a2054cf0195206411007217027f19089945c01e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.