commit | 4b4a433b5c9f61a25da9107e0e596b1cae3838a8 | [log] [tgz] |
---|---|---|
author | David Tseng <dtseng@google.com> | Tue Dec 01 22:28:12 2020 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 01 22:28:12 2020 |
tree | 6dd4104a2bdd42cb87e3a011e06a87b724feac51 | |
parent | a2eeadee3443e7720c91504f4df1888afda3e804 [diff] |
Process requests to bind TtsStreamFactory in order Scenario: - two (or more) component extensions request binding of TtsStreamFactory - requests are received in TtsService - there is only one concrete Receiver instance - each request closes the connection to any previously bound TtsStreamFactory connections As a result, any previous connections will be closed prematurely e.g. before the extension can call createGoogleTtsStream. Fix this by keeping around all PendingReceiver instances and process them whenever we can. Specifically, once the extension creates a specific tts stream, process the next pending request for a factory. Test: manual. Observe errors without this change in some rare timing instances where an extension gets a tts stream factory but is disconnected before creating a stream. Observe no such error with this change. R=dmazzoni@chromium.org Fixed: 1131321 Change-Id: Ie0a2803fff809ada42038001fa015e1a6fb63e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561540 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832545}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.