Google Git
Sign in
chromium / chromium / src / c0bf9e93f7c68d7305c1d3407311f14a77923ca1
commitc0bf9e93f7c68d7305c1d3407311f14a77923ca1[log] [tgz]
authorMichael Tang <tangm@microsoft.com>Tue Jan 17 22:59:07 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 17 22:59:07 2023
tree446890ef976d70da0026943e3f3169b04834880a
parent49d1cf15bf2e9c25c46033fa78ea07e92083ceae [diff]
viz: Fix overdraw feedback on OutputDevices that use RGBX/BGRX

Overdraw feedback uses `SkOverdrawColorFilter`, which relies on a buffer
with an alpha channel to work. We previously allocated the buffer for
overdraw feedback with the color type set on the
`OutputSurface::Capabilities` by the output device. When the desired
buffer format is RGBX or BGRX, we can end up with a color type with no
alpha channel.

This CL forces the overdraw target to allocate with an alpha channel,
regardless of the root surface color type.

Bug: 1408023
Change-Id: I8a0ccba36a148acfe4bdf3b94b6b57a98d00cf5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4166378
Commit-Queue: Michael Tang <tangm@microsoft.com>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1093556}
1 file changed
tree: 446890ef976d70da0026943e3f3169b04834880a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.