Google Git
Sign in
chromium / chromium / src / 4bbb947e2f136237c6ae5e75a9467653249aee28
commit4bbb947e2f136237c6ae5e75a9467653249aee28[log] [tgz]
authorJinsuk Kim <jinsukkim@chromium.org>Fri Apr 16 04:31:07 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 16 04:31:07 2021
tree81a6d12752d2881743688e7c152b86a5255eb1fc
parentde9a35f54058ffb0d11799c2d7a4479d09e4af92 [diff]
Omnibox: Dependency injection for chrome_java deps removal

This CL resolves several chrome_java dependencies. They have
a common pattern of injecting the dependency during construction
from ToolbarManager:

TabWindowManagerSingleton : injected the supplier of the instance
BookmarkBridge: Defined a new interface BookmarkState.isBookmarked
                 and injected it
DownloadUtil: Defined a new interface SaveOfflineButtonState.isEnabled
                 and injected it
IntentHandler: Injected a callback that brings a Tab to front.
WarmupManager: Injected a callback that spins up a spare renderer

Bug: 1171512
Change-Id: I220cf6aa34dd8f015e589925d2294e3e2f38f850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2823039
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#873195}
19 files changed
tree: 81a6d12752d2881743688e7c152b86a5255eb1fc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.