Always calculate accessible name out of accessibility tree.

AXNodeObject::TextFromDescendants was traversing the DOM tree
instead of the accessibility tree, to account for cases
that required calculation from nodes that were not part of the tree.
The main examples of this are certain labels, which were excluded from
the tree to prevent speech duplication between label + control, and
also name from a hidden subtree via aria-labelledby or describedby.
Also affects <portal> default titles and <ruby> descriptions.

After a set of patches to include any necessary nodes to the
accessibility tree, this CL enables calculating the name or
description out of the tree, instead of running a DOM traversal.
This greatly simplifies the implementation of TextFromDescendants.

This change collaterally fixes a problem with missing whitespace in
the accessible name. The cause was that the existing DOM traversal
removed all empty or whitespace text nodes, but they are present in
the cached tree as needed. Generally, the conditions for nodes to be
included in the name that were coded in TextFromDescendants are
now part of the accessible tree construction, mainly in
AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree.

The existing fix for name from ::before and ::after pseudonodes
(crbug.com/1199303) was to traverse the accessibility tree in that
case, so this patch will preserve that behavior and keep it fixed.

Bug: 1190132, 1199303, 1255036, 1276936
Change-Id: Ie17b5b951992affa5e690e2eededf224c322a493
AX-relnotes: include missing whitespace in accnames.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320230
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#955014}
23 files changed
tree: 80e51e56f44fe67620867834d3b3e48aec89d906
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.