commit | 4be1b31acb20b1da41f9ef846da0cb81f39ac183 | [log] [tgz] |
---|---|---|
author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Tue Mar 25 17:58:59 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 25 17:58:59 2025 |
tree | 9f93f8e610056875ec5c0caee2666aed9b489ede | |
parent | 401133ce39e9dea9a05b0cbadf0b6071cddb7090 [diff] |
Revert "[New Tab Animation] Cache context menu x, y origin" This reverts commit 0c124ebab37f9039b578675b0e2c93051785a883. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5325308900147200 Sample build with failed test: https://ci.chromium.org/b/8719415351421263633 Affected test(s): [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testContextMenuEntriesBeforeFirstRun](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.customtabs.CustomTabActivityTest%23testContextMenuEntriesBeforeFirstRun?q=VHash%3A9db0946a972712b3) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5325308900147200&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6388936&type=BUG Original change's description: > [New Tab Animation] Cache context menu x, y origin > > This CL caches the x, y coordinates of ContextMenuParams when using the > tab context menu. This is then used as the origin location of the > animation. > > Bug: 40282469 > Change-Id: I4de647aff949f9cc0451f872c5dcc7bf9745bcac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388936 > Reviewed-by: Dan Polanco <polardz@google.com> > Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1437484} > Bug: 40282469 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I57cd60a1bac721670c68adfa9ab800a8c91d1152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6392895 Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by: Dan Polanco <polardz@google.com> Cr-Commit-Position: refs/heads/main@{#1437608}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.