commit | 431944cdc5ea3f856dc9ecddbc1cd18b7e9d524d | [log] [tgz] |
---|---|---|
author | Matt Falkenhagen <falken@chromium.org> | Tue May 14 02:24:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 14 02:24:01 2019 |
tree | 03f069699149c3f6770dca976681896e3260a85b | |
parent | 9e54bad462fb56b46cd36bef230c5c4f38828f8b [diff] |
Don't set a size limit for the disk cache in APP_CACHE mode. In APP_CACHE mode, the eviction is somewhat disabled by design, but callers were specifying a size limit which caused eviction anyway. This was causing undesired eviction for service worker scripts, where we expect the quota manager to manage the space usage instead. This CL changes APP_CACHE callers use int64_max as the size limit, including service worker and appcache. The Cache Storage API was already using int64_max. Note that the int64::max is only respected by the Simple cache backend. Service worker uses Simple cache[1] while AppCache has a build flag that allows toggling between Simple and Blockfile.[2] The Blockfile backend goes up to int::max only. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_disk_cache.cc?l=12&rcl=c7a9d26cc435f6074ee2372fef360245524e2cf8 [2] https://cs.chromium.org/chromium/src/content/browser/appcache/appcache_disk_cache.cc?l=198&rcl=8e7751dff574550f053ff580f4c174dc54130c74 There is no test added because I can't think of a way to test this. Bug: 526915 Change-Id: I808a15312adaa3fc26c78eb165fa79dc13058aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608868 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659359}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .