commit 4c0e9d22c2d043801cbaea03f6cd29d27012f1dc
author Hiroki Nakagawa <nhiroki@chromium.org> Mon Oct 16 02:16:41 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 16 02:16:41 2023
tree 705034d76443aeb593ce4861a662987d1582356e
parent 65521cea5f9946a9bf84db1b0c21a86a230d80c6

Reland "Reland "Prerender: Use "use_prefetch" on PrerenderOmniboxSearchSuggestionBrowserTest""

This reverts commit 7ba5342e6f0a8466cd1f36480ec216744f990321.

Reason for revert:
The tests were failing on old Android bots (e.g., android-11-x86-rel)
because they hit the memory threshold check for prefetch and
prefetch/prerender unexpectedly didn't start.

To avoid the memory threshold check, in addition to the original CL,
this CL sets `device_memory_threshold_MB` field trial parameter on
`kSearchPrefetchServicePrefetching` flag to 0.

Original change's description:
> Revert "Reland "Prerender: Use "use_prefetch" on PrerenderOmniboxSearchSuggestionBrowserTest""
>
> This reverts commit b6b3d27d6bcc28de90b698d9ef4c9ba6fb02183b.
>
> Reason for revert: Breaking several android test bots.
>
> Original change's description:
> > Reland "Prerender: Use "use_prefetch" on PrerenderOmniboxSearchSuggestionBrowserTest"
> >
> > This reverts commit 099987654c234ae0739c5ae95025b9e774472bc8.
> >
> > Reason for revert:
> > In the original CL, the test attempted to activate a prerendered page
> > before prerendering was actually triggered and failed on expectations.
> > To fix the problem, in addition to the original changes, this reland CL
> > makes the test wait for the completion of prerendering and then navigate
> > to the prerendered page.
> >
> > Original change's description:
> > > Revert "Prerender: Use "use_prefetch" on PrerenderOmniboxSearchSuggestionBrowserTest"
> > >
> > > This reverts commit f0e44b5e0f15d6de68f77d976faa639d24e7731b.
> > >
> > > Reason for revert:
> > > PrerenderOmniboxSearchSuggestionExpiryBrowserTest.DifferentSuggestionAfterPrerenderExpired
> > > is failing on several bots:
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/Network%20Service%20Linux/70251/overview
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/13148/overview
> > >
> > > Original change's description:
> > > > Prerender: Use "use_prefetch" on PrerenderOmniboxSearchSuggestionBrowserTest
> > > >
> > > > Now the default "implementation_type" of prerendering for default
> > > > search engine is "use_prefetch" but the tests still use legacy
> > > > "ignore_prefetch". This CL fixes them.
> > > >
> > > > Notes
> > > > - This CL makes SearchPrefetchService become friend with
> > > >   PrerenderOmniboxSearchSuggestionBrowserTest so that the test can call
> > > >   SearchPrefetchService::CoordinatePrefetchWithPrerender() to expire
> > > >   prerendering. For the same reason, this chanegs the scope of anonymous
> > > >   namespace in the test file.
> > > > - This CL removes UpdateHistoryBeforeActivation() as the new
> > > >   implementation doesn't need to update a displayed URL after on
> > > >   activation.
> > > >
> > > > Bug: 1485775
> > > > Change-Id: I3d017909bd6b8fbd14381df2e3f911d54e7afd67
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885869
> > > > Reviewed-by: Lingqi Chi <lingqi@chromium.org>
> > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1203040}
> > >
> > > Bug: 1485775
> > > Change-Id: I7b384f93be4f697e3ddff0172bb809c3b5b3eea4
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4905004
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Reviewed-by: Lingqi Chi <lingqi@chromium.org>
> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1203077}
> >
> > Bug: 1485775
> > Change-Id: I472143f7d49e072b811e3fde4d5ea7968629a8fa
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4904524
> > Reviewed-by: Lingqi Chi <lingqi@chromium.org>
> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1203831}
>
> Bug: 1485775
> Change-Id: Iaed75f2a6100703cc2767f9c9d964e8a625aeeb5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4906623
> Reviewed-by: Sky Malice <skym@chromium.org>
> Auto-Submit: Brandon Wylie <wylieb@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Brandon Wylie <wylieb@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204072}

Bug: 1485775
Change-Id: I263d7ed0e73acc86b302b693f60ed847169b8d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4910634
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1209978}