Revert "[//gpu][mac] Support multiple concurrent read access in Graphite" This reverts commit d53449b702e7d67460467d25fdb14904bf79bca1. Reason for revert: It looks like this CL is likely still the source of crashiness, albeit now the crash is different: https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Mac%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BDump+without+crash%5D+dawn%3A%3Anative%3A%3ADeviceBase%3A%3AHandleError%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27+AND+product.Version%3D%27123.0.6304.0%27&stbtiq=&reportid=&index=0#2 Original change's description: > [//gpu][mac] Support multiple concurrent read access in Graphite > > We have discovered that the lack of this support is a source of > significant overhead for Graphite vs. Ganesh on at least one perf > benchmark, as this is supported in Ganesh [1]. > > This function was added here [2]. It's not obvious to me what the > requirements are for it being able to be supported in a given > representation. This CL enables it for > SkiaGraphiteDawnImageRepresentation for Mac. Local testing shows that > it works unproblematically, including on YouTube and WebGPU's demo > pages. > > NOTE: This CL is a reland of [3] (with the plumbing changes split out > to a predecessor CL). The test crashes that caused a revert are fixed > in [4]. > > [1] https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/shared_image/iosurface_image_backing.mm;l=373-375;drc=b58207f5aecc39db7d3da766e7d171e5d2c3598e;bpv=1;bpt=1 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1963098 > [3] https://chromium-review.googlesource.com/c/chromium/src/+/5250233 > [4] https://chromium-review.googlesource.com/c/chromium/src/+/5296634 > > Bug: 41496467 > Change-Id: I5b26080c5605b9dcf8e25c649370fa8a01a391ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300195 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1261076} Bug: 41496467 Change-Id: Ib86e70a0ef0132dd4192f4dfffa0ca124a4a3a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300566 Auto-Submit: Colin Blundell <blundell@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1261627}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.