Google Git
Sign in
chromium / chromium / src / 4c9311a8c9a06dbf1f409d780e3462b48006e815
commit4c9311a8c9a06dbf1f409d780e3462b48006e815[log] [tgz]
authorJustin Novosad <junov@chromium.org>Wed Jun 16 18:12:31 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 16 18:12:31 2021
tree2cd54ad7743aa3a50520e2858ca83f1488bf9312
parent19c2bebe7d521d945f0430d18df076cab1a3962e [diff]
[Canvas] Simplify DidDraw methods (Reland)

This is a code cleanup related to DidDraw methods throughout
canvas-related code in blink. This CL removes unnecessary overloads,
unnecessary virtuals, unnecessary argument passing. In WebGL
rendering contexts, we remove an unnecessary recursion cycle. In
2D contexts, we remove an unnecessary and confusing virtual method
multiple inherritance name conflict (method renamed to DidDraw2D
in BaseRenderingContext2D)

Difference from original CL that was reverted: removed changes
to dirty_rect calulations in html_canvas_element.cc

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2947051/

Bug: 1217714
Change-Id: I98a2b87418389adfe368a2a7cb2c1175e3cc221e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965277
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893061}
20 files changed
tree: 2cd54ad7743aa3a50520e2858ca83f1488bf9312
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.