Google Git
Sign in
chromium / chromium / src / 4c9ad549ad998d5650685503f75fd53f1022560a
commit4c9ad549ad998d5650685503f75fd53f1022560a[log] [tgz]
authorDana Fried <dfried@chromium.org>Mon Dec 13 19:44:09 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Dec 13 19:44:09 2021
tree2d9ed6552ae9dbe541ab770c62c907feeeb1bf7f
parentbd399a8c5145efa3dc4684daaab1b0d536a5411d [diff]
Background tab adds before group discontinuity.

Previously, a new tab opened in the background from a link would always
add immediately after the last tab associated with the opening page.
However, if one or more intervening tabs are added to a group -
especially one potentially containing unassociated tabs - the new tab
can appear after the group or even inside the group, with the unrelated
tabs.

This change will place the new background tab to the right of the
opening tab, ideally after the final tab associated with the opening
tab, but if there is a group discontinuity, immediately before the
discontinuity instead.

For example:

O = opener
* = associated tab
. = unassociated tab
^ = new tab position
[] = group membership

O * * * * ^ . . .

O * * ^ [* * .] . .

[O * * ^] * * . . .

O * ^ [* *] * . . .

Bug: 1246421
Change-Id: Ife2f1a87f6b9b9fd9517b26dfe175e549fa2df18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330925
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951138}
1 file changed
tree: 2d9ed6552ae9dbe541ab770c62c907feeeb1bf7f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.