commit 4d01087f7019a79524b1f66ce2b4b1067c995ed0
author Sammie Quon <sammiequon@chromium.org> Tue May 16 21:18:54 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 16 21:18:54 2023
tree f7be31354749c8e84e390d7107fb0427e6caec1e
parent 5ba7a2f3bb1255a1d505fe9a00514dda70682cd7

overview: Fix issue with overview clip not removed when combining desks

This bug would occur whenever combining desks with non-chrome windows
in overview. Combining desks will remove the existing overview items,
then add them back with the associated desk.

Removing the item will trigger a clip animation to reshow the header.
Since we want an animation, we have to animate the clip to the size
of the window, then remove it after the animation ends, so we have
an intermediate clip.

By removing the existing overview item, and then adding it back, the
target clip is actually the intermediate clip. For this case, removing
the clip (as well as transform and opacity) with animation has no
visually differences so the fix is on combine, we remove the items
without animation.

Test: manual, ash_unittests *OverviewSessionTest.WindowClippingAfterCombiningDesks*
Change-Id: I828ba93e63bc33f09584d6ceeb7b1924f2266854
Fixed: b/282010852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4533139
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144917}