commit | 4d27f956a89be9eddf33c8b94d668429b7db43cf | [log] [tgz] |
---|---|---|
author | chinsenj <chinsenj@chromium.org> | Mon Nov 15 22:23:43 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 15 22:23:43 2021 |
tree | 32adf9c50ec143c27c67e9de78145e0e03c0e603 | |
parent | 79f740843c57ec294ee1c029f990271af2d18c6a [diff] |
Reland "desk_templates: Prevent exiting overview when dialogs close" This is a reland of 66ee274344ef85f9ee4f482c3c01eeb59343b624 It fixes the flakiness by using `WaitForUI()` instead of `RunUntilIdle()` which waits on async DeskModel changes. Original change's description: > desk_templates: Prevent exiting overview when dialogs close > > Currently when users accept or cancel a dialog it will close overview > due to the dialog's window being activated and then destroyed, making > the activation client activate the next activatable window. > > This CL prevents this by making the OverviewSession not end overview > when a dialog loses activation (it already does this when the dialog > gains activation). > > Test: modified > Bug: 1269444 > Change-Id: Ia527e6ce9d69bcf6be77987a27af3467a0aadac8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275745 > Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/main@{#941292} Bug: 1269444 Change-Id: I737ff5dba0d970c543c52ab1cb44b21961360e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282953 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/main@{#941857}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.