Google Git
Sign in
chromium / chromium / src / 4d2a3fd469b401b3fb2e1dcaed0ce7b38b201fcc
commit4d2a3fd469b401b3fb2e1dcaed0ce7b38b201fcc[log] [tgz]
authorAshley Prasad <ashleydp@google.com>Mon Apr 04 22:04:49 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 04 22:04:49 2022
treefe44fcbb5188e8c15770d9908a47521f38bb45f4
parentae65d438b1dfffad093cf9a6cf0884cc6ae20367 [diff]
diagnostics: add browser delegate interface

- Add DiagnosticsBrowserDelegate as ASH_EXPORT interface in preparation
  for adding implementation code.
- Add delegate to BUILD.gn files.
- Add initialized concept to diagnostics_log_controller to inform
  callers if the current instance is ready for use.
- Test initialized status before and after setting the delegate
  property.

Bug: b:225191282
Test: Run unit_tests and ash_unittests. Manually deployed and tested with flag on and off that there are no failures.
Change-Id: Ie0bbc3ea6c30a0499b0de112708f3e3dbd82cbd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543334
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Commit-Queue: Ashley Prasad <ashleydp@google.com>
Auto-Submit: Ashley Prasad <ashleydp@google.com>
Cr-Commit-Position: refs/heads/main@{#988701}
6 files changed
tree: fe44fcbb5188e8c15770d9908a47521f38bb45f4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.