commit | 4d4eac58d2748ce9c99e46eece06e81b5f213b9a | [log] [tgz] |
---|---|---|
author | Piotr Bialecki <bialpio@chromium.org> | Fri Apr 08 23:33:50 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 08 23:33:50 2022 |
tree | 1c9f4a4ba8824b6247030a19c5ff0dd9ee19a980 | |
parent | f6cdfcf1f0b2a262ccb2b6e31342318ff41f7e88 [diff] |
Fix DCHECK in skia renderer when resizing captured tab When resizing captured window, the output rectangle of the drawn render pass may be different than what the caller of CopyOutputRequest API expected, and thus it may not meet the requirements of the pixel format. This could trigger a DCHECK when reading back the results to populate the CopyOutputResponse. Changes: - Move `MinimallyShrinkRectForI420()` to media_util.[h/cc]. - Adjust result_selection on RenderPassGeometry to account for pixel format requirements. - Minor: pass RenderPassGeometry by const-ref to `CopyOutput()` in `SkiaOutputSurfaceImplOnGpu` Change-Id: I47c0f0b929449d6d90b936ae04ce5b7e643c3252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551199 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/main@{#990657}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.