[PDF Ink Signatures] Re-work backend -> frontend API Clicks will be handled by the PDF internal plugin and forwarded to the PDF viewer. It is the PDF viewer's responsibility to initialize a text annotation based on these clicks. This CL: - Removes handling for the 'updateTextBoxRect' message, which is now no longer planned. - Adds click forwarding from the internal plugin to the viewer. - Adds a method on Ink2Manager to initialize a text annotation based on the click position; if click is not on a page, click is ignored. - To support this, at a new getPageAtPoint() method on the viewport and corresponding tests. - Note: Ink2Manager sends full information (including styles, page number, etc) about the annotation to be edited in the initialization event, as opposed to only location information as in the earlier prototype which was based on the never-implemented backend updateTextBoxRect message. - Note 2: Ink2Manager initializes the text box using screen coordinates instead of page coordinates. This CL does not add: - Logic for determining whether the click is on an existing or new annotation - Page boundary enforcement for annotations. - Updates to the frontend -> backend messages. Bug: 402546155 Change-Id: Ic2a5cb9979db00bc75d6d41b5078bf154d219b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6499128 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Andy Phan <andyphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1454553}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.