commit	4dbedadecc16a6769451f30751ee52f259874a21	[log] [tgz]
author	Patrick Noland <pnoland@chromium.org>	Mon Aug 10 18:29:41 2020
committer	Commit Bot <commit-bot@chromium.org>	Mon Aug 10 18:29:41 2020
tree	d325a76ba3e09922e9392197e3a230f8288254d2
parent	422feef87668b7bf9e6ad76a0cc42bda89b11dbb [diff]

[ToolbarMVC] Create menu_button package and MenuButtonCoordinator

This starts the process of hiding the MenuButton view behind the coordinator. Primarily, ToolbarAppMenuManager (renamed to MenuButtonCoordinator) now directly manipulates the MenuButton instead of doing so through TopToolbarCoordinator. MenuButton related functionality is removed from the Toolbar interface, with a few mechanical adjustments to match.

Bug: 1086676
Change-Id: I9d8e63e320feec671df5cbd82aed9e330b543865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327315
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796471}

chrome/android/chrome_java_sources.gni[diff]
chrome/android/chrome_junit_test_java_sources.gni[diff]
chrome/android/java/res/layout/bottom_toolbar_menu_button.xml[diff]
chrome/android/java/res/layout/menu_button.xml[diff]
chrome/android/java/res/layout/toolbar_tablet.xml[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BottomControlsCoordinator.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BottomToolbarCoordinator.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/TabSwitcherBottomToolbarCoordinator.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButton.java[Renamed from chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java - diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButtonCoordinator.java[Renamed from chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarAppMenuManager.java - diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbar.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/StartSurfaceToolbarView.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TabSwitcherModeTTPhone.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/Toolbar.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java[diff]
chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarCoordinator.java[diff]
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhoneTest.java[diff]
chrome/android/junit/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButtonCoordinatorTest.java[Renamed from chrome/android/junit/src/org/chromium/chrome/browser/toolbar/ToolbarAppMenuManagerTest.java - diff]
chrome/android/junit/src/org/chromium/chrome/browser/toolbar/menu_button/MenuButtonTest.java[Renamed from chrome/android/junit/src/org/chromium/chrome/browser/toolbar/MenuButtonTest.java - diff]

22 files changed

tree: d325a76ba3e09922e9392197e3a230f8288254d2

README.md

Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.