[Autofill] Fix AutofillField's current value during import

FormStructure::RetrieveFromCache() for kFormImport resets each
field's value to the empty string if that field
- hasn't changed its value (current value == initial value) and
- is not a <select>.

The idea is that if the user didn't change an <input>'s value, its
value carries no meaning and can be ignored for form import.

The downside of this mechanism is that it creates ambiguity of
FormFieldData::value() / AutofillField::value(): its semantics
depends on whether the owning FormStructure was created in the
context of a form submission or not.

Now that each AutofillField knows its initial value, we can defer
the decision whether a value is relevant for import and avoid this
ambiguity.

This CL therefore introduces AutofillField::value_for_import(), which
applies the filters from FormStructure::RetrieveFromCache(kFormImport) toAutofillField::value(kCurrent).

As a by-product, value_for_import() also inlines the checks that
give precedence to FormFieldData::selected_option()->text.

This change preserves equivalence with one exception: when an
<input> is first seen in the submission and thus doesn't exist in
the cached form, then
- the *old* behaviour does not reset the value because
  RetrieveFromCache() doesn't find an initial value, whereas the
- the *new* behaviour does reset the value because the
  value(kCurrent) == value(kInitial).
6% of Autofill's and 0% of Password Manager's captured-site tests
contain such fields (and PWM doesn't use value_for_import() anyway).
This behaviour change shouldn't matter in the real world because when
a field is manually filled or autofilled, it is added to the cache
(except under extreme conditions).

All changes are behind the feature kAutofillFixCurrentValueInImport.

Bug: 40227496, 40232021
Change-Id: Id2f87f40f3cb2d0a33df31316251b541d867d12c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874041
Reviewed-by: Dominic Battré <battre@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1358540}
21 files changed
tree: 8d9822496875d19a75c1e7e33c5cfe40f4ca4d31
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.