commit | 4e0fd3177faf0fd5dadbcfa311e31e62db8f7324 | [log] [tgz] |
---|---|---|
author | Ashley Newson <ashleynewson@chromium.org> | Tue Oct 22 13:33:19 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 22 13:33:19 2024 |
tree | 2b321303593a274ee9d98fabbcb7856ef28de162 | |
parent | 97d6af914ae64b58cbd0d3e20726fafa644ad3a7 [diff] |
Revert "Reland "[UPMAccessLossWarning] Add a fieldtrial test config"" This reverts commit 6106906f066433409fa1f09fe2058a3e4df25dfd. Reason for revert: There was a distinct set of test failures across multiple bots unrelated to the false-positive example given in the reland. This change (original and reland) correlates with failures in the test histories and was bisected as the culpit both originally and in the reland. Whilst automatic bisect happened on non-gardened bots, the issue is also present on gardened bots (e.g. android-pie-arm64-rel). (https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5859516345221120, https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5191949846839296) Original change's description: > Reland "[UPMAccessLossWarning] Add a fieldtrial test config" > > This is a reland of commit 5ee23f54d09ebe4adc100689c6afd0fae3cc3c0f > > The revert was speculative because of this failed build at Oct 18 14:57 > https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-arm64-rel/41133/overview > The build after it succeeded at Oct 18 19:12 > https://ci.chromium.org/ui/p/chromium/builders/try/android-pie-arm64-dbg/9344/test-results?sortby=&groupby= > But the next one failed again Oct 18 19:30 > https://ci.chromium.org/ui/p/chromium/builders/ci/android-pie-arm64-dbg/19841/test-results?sortby=&groupby= > This proved that the CL wasn't the culprit after all, so I'm > relanding it. I also ran the test locally and the failure didn't > reproduce. > > Original change's description: > > [UPMAccessLossWarning] Add a fieldtrial test config > > > > This CL adds the test config for the password access loss warning > > feature. > > > > Bug: 323149739 > > Change-Id: I2b062c6b68ea82ff997378e0c45a2cd6df32337e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5928986 > > Commit-Queue: Ivana Žužić <izuzic@google.com> > > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1370513} > > Bug: 323149739 > Change-Id: Id719a6a33110dd5de7e5a80116f53c8a85ef7012 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5945046 > Commit-Queue: Ivana Žužić <izuzic@google.com> > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1371338} Bug: 323149739 Change-Id: I9bdb7b2fde5aa5ecd43b15dde45b7b37c774c545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953265 Commit-Queue: Ivana Žužić <izuzic@google.com> Commit-Queue: Ashley Newson <ashleynewson@chromium.org> Owners-Override: Ashley Newson <ashleynewson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ivana Žužić <izuzic@google.com> Cr-Commit-Position: refs/heads/main@{#1371995}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.