Add more precise tests for ::highlight() styles in the MPC.

For an MPC entry to match (when applying ::highlight() styles),
we'd test:

  1. Inherited properties, including inherited variables,
     match between the two parent styles.
  2. Non-inherited properties must also match. (Sometimes, we test
     this twice when there's explicit inheritance, which isn't
     relevant for this issue.)
  3. Highlight-specific properties, including inherited variables,
     match between the originating element's styles.

However, this means that we test that InheritedVariables() must be
equal to two different styles (in #1 and #3), and if those sets
of variables differ, we can end up with an MPC entry that cannot
match anything. Yet, we insert it, and if combined with
custom highlights in universal selectors, we can end up with more
and more can-never-match-anything elements in the same bucket.

Thus, make proper testing for ::highlight() styles, where we test
only what needs to be tested, reducing the number of false positives.

There's a separate bug in step 3, which will be fixed in the next patch.

Bug: 461993670
Change-Id: I23d5edbd8a29917c2b8b9f59c96485c687d40355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7172543
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1548375}
2 files changed
tree: 3285eea6de4b765a774a37d3c5ae0d2351c5ed3e
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.