Google Git
Sign in
chromium / chromium / src / 4e455176f1abb79966846fbead9557f98cd852c8
commit4e455176f1abb79966846fbead9557f98cd852c8[log] [tgz]
authorShakti Sahu <shaktisahu@chromium.org>Sat Jun 28 00:50:04 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jun 28 00:50:04 2025
tree2acccf4075609228d6ec2212533440179aae30e9
parentd105be3bbe132346b3157582a3b5dfe4d56a9da8 [diff]
[M139] [Versioning] Better checking of feature flags in the controller

This CL adds:
1. VersioningMessageController would check for both flags (sync data
type flag and the update chrome message UI flag) when invoked from UI.
2. Tests for various combinations of feature flags.

(cherry picked from commit c5b402637a5ed4e5b1f9ea84415d10fec126f87d)

Bug: 420675818
Fixed: 427792515
Change-Id: Ia3fe218fe5dcf368b567683001c6dfb3599bc1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6659060
Reviewed-by: Ritika Gupta <ritikagup@google.com>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1478260}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6685227
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/branch-heads/7258@{#244}
Cr-Branched-From: f600d0656fd5b5fe4a82981f533d31ed6939e2e4-refs/heads/main@{#1477651}
2 files changed
tree: 2acccf4075609228d6ec2212533440179aae30e9
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.