Google Git
Sign in
chromium / chromium / src / 4e822c94e5a7dd7744a2209bcc9418884932fdca
commit4e822c94e5a7dd7744a2209bcc9418884932fdca[log] [tgz]
authorSammie Quon <sammiequon@chromium.org>Wed Sep 22 01:05:29 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 22 01:05:29 2021
tree34e580be15bd0ca88920b54caf873797a1934654
parenta761d205472100e97880c73a240ec0b26bb654f1 [diff]
desks: Add a flag with tentative improvements for swiping desks.

Tested locally and like the improvements, but want feedback from more
people and more devices (namely UX), so introduced a feature flag to
tentatively hide these improvements.

The main issue we are seeing is that "fast swipes" are not working as
user intends. Fast swipes can fail due to:
- starting screenshot not taken
- starting screenshot taken but ending screenshot not taken
- user has not seen 10% of the next desk

This patch attempts to solve the latter two. If feedback is positive we
could explore solving the former, but that is a bit more tricky. In
addition to removing the 10% seen threshold, we let the ending screenshot
callback finish and start an animation when it is, just like keyboard
release.

Test: manual, added
Bug: 1191545
Change-Id: I86a86d6e5f51670bff192132fe6a0a0685f8e7b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169038
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923671}
10 files changed
tree: 34e580be15bd0ca88920b54caf873797a1934654
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.