commit | 4f3648603a22f2fdccd1732cd1a1bce7003bc90f | [log] [tgz] |
---|---|---|
author | Xiyuan Xia <xiyuan@chromium.org> | Fri Jun 27 18:21:59 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 27 18:21:59 2025 |
tree | fe6a4ed07ce9b7e27f6464b0de8a868dc68a85eb | |
parent | fba0504478a1c27a243bde282102fec337fa6b9f [diff] |
[Accessibility Common] Share message processing Ensure only one chrome.runtime.onMessage listener exists in the offscreen document. Route incoming messages to appropriate handlers to maintain modular logic. In Chrome extension messaging, only the first registered onMessage listener is invoked. If it returns false or nothing and doesn’t call sendResponse synchronously, Chrome treats the message as handled and closes the port. This affects both synchronous and asynchronous messages, and can lead to the error: "The message port closed before a response was received." To avoid dropped responses and ensure consistent behavior, message handling should be centralized. Changes on top of crrev.com/c/6563668: - Move message handling into `Messenger` so that service worker side could share message processing too. AX-Relnotes: n/a. Bug: 388867838 Change-Id: I1f2146a307e331be74693e37948f83029dd75124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680169 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1479963}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.