commit | 4f448dfe49b097a1213a1cc7803772323b0395e0 | [log] [tgz] |
---|---|---|
author | Elly Fong-Jones <ellyjones@chromium.org> | Fri Nov 05 17:34:51 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 05 17:34:51 2021 |
tree | acb2525ad88ad7b69242eb3cb0ba5c53438fba8c | |
parent | 2f37b5011319136a22fa53b6b7a4880d911f27a7 [diff] |
Revert "zoom: refactor ChromeZoomLevelPrefs" This reverts commit f487dcfb79591e7eea8581f2317a8197b788a055. Reason for revert: https://crbug.com/1267308 Original change's description: > zoom: refactor ChromeZoomLevelPrefs > > This change refactors this class with the primary goal of getting rid of > uses of the deprecated base::DictionaryValue shim class. Specifically, > it: > > 1. Reworks ExtractPerHostZoomLevels to no longer support leaving > invalid keys in the pref dictionary > 2. Removes the backward-compatibility path where the zoom level > isn't stored as a dictionary but rather as a single double > 3. Removes a redundant deep copy of the host map > 4. Reworks GetTimeStamp into TimeFromString, and generally makes more > use of absl::optional and less use of the out param + bool return > pattern > > Bug: 420643 > Change-Id: I3c875847c3ad11dc55cf28b68a8c63dee526e6c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3015672 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: W. James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/main@{#938406} Bug: 420643 Change-Id: I83a735591162da6b4c969dd2b46813804c4864f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3264404 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Owners-Override: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/main@{#938841}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.