Google Git
Sign in
chromium / chromium / src / 4f780e75894132c42e394aff97de2d654cf8cfe1
commit4f780e75894132c42e394aff97de2d654cf8cfe1[log] [tgz]
authorMarc Treib <treib@chromium.org>Tue May 04 19:56:34 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 04 19:56:34 2021
treedd8b510514f31bd5db1003ba27d17d85116fab86
parent2130241ac066c243c2226d46cafd4cf4862a0cdc [diff]
FCMInvalidationServiceBase: Consistently notify about the client ID

FCMInvalidationServiceBase has a client ID aka InstanceID, which is
exposed to InvalidationHandlers via OnInvalidatorClientIdChange().
Before this CL, there was one sequence of events where handlers were
*not* informed about the client ID:
1) Handler registers itself (RegisterInvalidationHandler).
2) FCMInvalidationServiceBase gets initialized and restores the client
   ID from prefs, but does *not* notify handlers. <- This is the bug!
3) FCMInvalidationServiceBase receives a fresh (validated) client ID
   in OnInstanceIDReceived(), but it's (typically) identical to the
   previous, cached one, so it doesn't notify handlers.

This CL adds a notification to handlers in step 2, after the client ID
is read from prefs. It also adds a test about client ID notifications.

Bug: 1203521
Change-Id: I18d84a0ea46d52062485a05ebb9627fc4d3bae83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2871607
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#879010}
5 files changed
tree: dd8b510514f31bd5db1003ba27d17d85116fab86
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.