Google Git
Sign in
chromium / chromium / src / 4f963cf553d991d3729aa821b2eca1083370ea5d
commit4f963cf553d991d3729aa821b2eca1083370ea5d[log] [tgz]
authorDylan Cutler <dylancutler@google.com>Wed Jul 27 23:45:26 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 27 23:45:26 2022
tree1d4095c8659c7916c4961a8be53fd2745da7952b
parent4afa8fcd7739f786a2e34b55b2ea814e15857d61 [diff]
Dump without crashing in renderer on RCM mismatch

The purpose of this CL is to add logging on the renderer side when there is a mismatch between what the renderer tells RCM what the site for cookies and top frame origin should be and what the browser process thinks they should be.

morlovich@ have tried adding logging on the network service side in https://crrev.com/c/3168933 and from the crashes reported in https://crbug.com/1251118 we determined that the mismatch happens in the SetCookieFromString method.

My thinking is that by logging when this happens on the renderer side we can gain additional insight into the cause of this bug.

Bug: 911299
Change-Id: I158b7ca8ebffdce53e0283c4cae50b482e7e39c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3770740
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1028993}
5 files changed
tree: 1d4095c8659c7916c4961a8be53fd2745da7952b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.