| commit | 4f986bd9f5e1d0b1388eade964060fc80021e425 | [log] [tgz] |
|---|---|---|
| author | Ben Pastene <bpastene@chromium.org> | Fri Mar 22 21:33:39 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 22 21:33:39 2024 |
| tree | 3d786a7633a2ae187736a99a3c4a7fd2df21d075 | |
| parent | 5f08c97efbf524622c7100f76c2c6470619955da [diff] |
utr: Absolutize the custom build_dir path when passed to recipe
Passing a custom build_dir to the utr today fails when the path is
relative with the error:
Uncaught Exception: AssertionError('out/Release_CI/args.gn is not absolute')
So this just absolutizes the path before handing it off to the recipe.
The recipe could theoretically absolutize the path on its end,
but path manipulation is remarkably difficult/complicated in recipes.
So easier to just do it in the script-side.
Bug: 41492688
Change-Id: I5ca9c1c1a9ac84d0e038e304050489ef52cb0b2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385322
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277097}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.