commit | 4fd305eac03b3d0db5059510baef81fb209931fb | [log] [tgz] |
---|---|---|
author | Xiaocheng Hu <xiaochengh@chromium.org> | Tue Aug 31 23:09:54 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 31 23:09:54 2021 |
tree | 3abc5e69fdc8a4d78ed6d0b1042e92332e16c45a | |
parent | f630a7dae88a827055e8386b5af0663567b31e69 [diff] |
Revert "Make all rule lists in RuleSet sorted by rule position" This reverts commit 2bf36c2d89ed9c19948b95fb58e8057baad70b11. Reason for revert: Caused memory regressions crbug.com/1244244 Original change's description: > Make all rule lists in RuleSet sorted by rule position > > Currently, all rule lists in RuleSet are sorted by rule position, except > the id, class, tag and UA shadow pseudo element rules, which are stored > in a CompactRuleMap. > > This is because CompactRuleMap is built by first storing rules in a > linked stack (to avoid memory pre-allocation and fragmentation), and > then transferring the rules to a vector. As a result, the rules in the > vector are in reversed order. > > This patch makes RuleSet use a linked queue instead, so that after > transferring the rules, the result rule list is still in the sorted > ordering. > > Note: This is preparation for crrev.com/c/3114419, which requires all > rule lists to be sorted by rule position. > > Bug: 1095765 > Change-Id: I911399831df3d7f75a428cdd851eb9279be33fa6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3119837 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#916011} Bug: 1095765, 1244244 Change-Id: I1b0d28280a640b88cf31f2b9090a066383536852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3133904 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#917016}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.