commit 4fda22e160e016227e8fed76c80523df0acce6de
author Titouan Rigoudy <titouan@chromium.org> Tue Jun 07 21:14:56 2022
committer Prudhvikumar Bommana <pbommana@google.com> Tue Jun 07 21:14:56 2022
tree cfc2c20d31984f673806dd4b90f5ddf8453fb10b
parent 97bd3bfd58a499f6bb7d28a19d62b6332febb259

[Merge] [Private Network Access] Avoid notifying about closed socket.

This can happen due to the following race in the network code:

1. Socket is re-used from socket pools, `SocketPosix::IsConnected()`
   returns true.
2. Remote side closes the socket.
3. `HttpStream::GetRemoteEndpoint()` fails during
   `HttpNetworkTransaction::DoConnectedCallback()` because the socket is
   not connected anymore

The race caused flakiness when establishing connections to non-public
servers that do not serve `Connection: close` headers yet support only a
single request per socket. This is the case for some web platform tests.

Tested this manually by running the flaky test 5000 times with no
flakes. Previously it would fail once every couple hundred times fairly
reliably.

(cherry picked from commit 5cf08f1bfdc34ca9b68520d12f7dd61177384dd3)

Fixed: chromium:1322072
Change-Id: I8cdbf52d04cbec3f52a1d3e0a8a7779bd4346605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652198
Reviewed-by: David Benjamin <davidben@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1005811}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3692108
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#659}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}