| commit | 2a3004d500c1e725e62b861d06f2a22d652d6b03 | [log] [tgz] |
|---|---|---|
| author | dmblack <dmblack@google.com> | Thu Jan 09 23:28:32 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 09 23:28:32 2025 |
| tree | ca0c18ad3dbf91ed341cf3858cbfd7e0a2cfb14a | |
| parent | 80f8684d19218fc4a17e2971c1726ae38686ba3a [diff] |
Update how `ScopedBookmarkModelObservation` fetches child nodes. Previously `ScopedBookmarkModelObservation` fetched child nodes using `BookmarkBridge#getBookmarksForFolder()`. Now, it fetches child nodes using `#getChildIds()` and `#getBookmarkById()`. This circumvents an issue where `#getBookmarksForFolder()` would fail to return children of the local bookmark bar node when the user is not signed in. Bug: 347632437 Change-Id: I9daa43c58efa37c6523e0e514684916caeaf7b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6143036 Reviewed-by: Brandon Wylie <wylieb@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/main@{#1404472}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.