Google Git
Sign in
chromium / chromium / src / 505063c0cb6ade31a4066eac03e00b6521e761fa
commit505063c0cb6ade31a4066eac03e00b6521e761fa[log] [tgz]
authorMason Freed <masonf@chromium.org>Sat Jul 17 23:33:23 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jul 17 23:33:23 2021
tree784b94dd8ed025d5eded8eb5c5a3896a242c8195
parentd054f9df29b0ea7aa12dbfd0c68bb63baff5a449 [diff]
Fix a few bugs in declarative Shadow DOM cloning

Previously, the cloning operation would fail if the declarative shadow
root was sufficiently nested (e.g. inside another <div> or inside a
nexted <template>). This CL fixes this bug, by passing through the
CloneChildrenFlag to all the places it's needed.

Two new test conditions are added for the two broken cases.

Fixed: 1229311
Change-Id: I3e1fe7e6075e1aa74ff753c66ee209bd08a8a29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033299
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#902843}
6 files changed
tree: 784b94dd8ed025d5eded8eb5c5a3896a242c8195
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.