[Autofill] Merge `believe_server` into PreferHeuristicOverServer()
Before this CL, we have:
bool PreferHeuristicOverServer(...) {
return Foo();
}
if (!PreferHeuristicOverServer(...)) {
bool believe_server = ...;
if (believe_server) {
Bar();
}
}
After this CL, we have:
bool PreferHeuristicOverServer(...) {
if (Foo()) {
return true;
}
bool believe_server = ...;
return !believe_server;
}
if (!PreferHeuristicOverServer(...)) {
Bar();
}
This CL is a no-op: The old and new code both call Bar() iff
!Foo() && believe_server.
Two followup CLs simplify the resulting code.
Bug: 40100455
Change-Id: If6b33de66ecd134de7ac3da825bf10459f08b6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6830403
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1498672}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.