Google Git
Sign in
chromium / chromium / src / 50cb5c61433c4b554b17ad6baf6c4a8234bdadcd
commit50cb5c61433c4b554b17ad6baf6c4a8234bdadcd[log] [tgz]
authorLingqi Chi <lingqi@chromium.org>Tue Nov 26 14:48:04 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 26 14:48:04 2024
tree100eab5562457cbee3da451abc469bcd0d8d8e22
parent0b2925ee441b19784a1060090b82a3554bccb696 [diff]
[text-box-trim] Retire text-box-edge propagation restriction

We added a restriction that the effective text-box-edge can be
propagated to its child only if the same node defines a non-initial
text-box-trim value when text-box-edge is not inherited.
But now the specification is updated[1] which marks text-box-edge as
inherited, and we no longer need this restriction.

This CL also removes
text-box-trim/text-box-trim-ignore-nested-text-box-edge.html
from the web-test. This test was replaces by
text-box-trim-not-ignore-nested-text-box-edge.html (each test
disagrees with the other) since [2], but for some reasons still stays
at the wpt codebase.

A follow-up will retire the EffectiveTextBoxEdge field.

[1] https://github.com/w3c/csswg-drafts/issues/10904
[2] https://github.com/web-platform-tests/wpt/commit/288ee9d3430ff09a227f1c96b3cbb25170ab1af4

Bug: 367766472, 374787320, 40254880
Change-Id: I789136ef54fa2d0c8b7a97b08caf1217512d10c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038647
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388218}
4 files changed
tree: 100eab5562457cbee3da451abc469bcd0d8d8e22
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.