Google Git
Sign in
chromium / chromium / src / 5150754880affddb3836d38db5ca30a0c53a70c0
commit5150754880affddb3836d38db5ca30a0c53a70c0[log] [tgz]
authorClark DuVall <cduvall@chromium.org>Thu Jun 02 00:51:16 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 02 00:51:16 2022
tree093983ef00cdff010824ae5623246bc4dc28cdfe
parentf6a678ef2f308790354b5dc23d4ff82ed02d45ab [diff]
Avoid script context being created too early in ExtensionFrameHelper

The call to ScriptContextSet::GetMainWorldContextForFrame() in the
GetExtensionFromFrame() function can force a script context to be
created if one does not exist yet for the frame. This can reduce the
benefit of optimizations which try to run before the script context is
created such as http://crrev.com/c/3656060 and
http://crrev.com/c/3400186.

This change moves the extensions logic to DidCreateScriptContext() which
will be called when the script context for the frame is created. The
change is behind a base::Feature since it may have a measurable impact
on performance.

Bug: 1328448
Change-Id: Id0e5d887e93d4ad51bd5e2baa9b5b868597c0d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674405
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1009885}
5 files changed
tree: 093983ef00cdff010824ae5623246bc4dc28cdfe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.