commit | 5150754880affddb3836d38db5ca30a0c53a70c0 | [log] [tgz] |
---|---|---|
author | Clark DuVall <cduvall@chromium.org> | Thu Jun 02 00:51:16 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 02 00:51:16 2022 |
tree | 093983ef00cdff010824ae5623246bc4dc28cdfe | |
parent | f6a678ef2f308790354b5dc23d4ff82ed02d45ab [diff] |
Avoid script context being created too early in ExtensionFrameHelper The call to ScriptContextSet::GetMainWorldContextForFrame() in the GetExtensionFromFrame() function can force a script context to be created if one does not exist yet for the frame. This can reduce the benefit of optimizations which try to run before the script context is created such as http://crrev.com/c/3656060 and http://crrev.com/c/3400186. This change moves the extensions logic to DidCreateScriptContext() which will be called when the script context for the frame is created. The change is behind a base::Feature since it may have a measurable impact on performance. Bug: 1328448 Change-Id: Id0e5d887e93d4ad51bd5e2baa9b5b868597c0d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674405 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009885}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.