Google Git
Sign in
chromium / chromium / src / 51516b58dba3af95d47e79a90b47662fde50ab31
commit51516b58dba3af95d47e79a90b47662fde50ab31[log] [tgz]
authorSylvain Defresne <sdefresne@chromium.org>Fri Jun 23 11:03:51 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 23 11:03:51 2023
treebe3a5b7d668c5afb5cec7721e42c1338888e0c25
parent0616561e4143a98f135cac951633d3e6ffd0ac91 [diff]
[ios] Use unique identifier to name WebSession storage

Change WebSessionStateCache to use GetUniqueIdentifier() to generate
the file name of the session storage on disk. The migration happens
when the file are loaded by renaming them if they are still using the
old name (derived from GetStableIdentifier).

This change will allow deprecating GetStableIdentifier (the value
will still exist and will still be saved when using the current
serialisation code). Additionally, as the new serialisation code
won't save the GetStableIdentifier, this change allow having the
unchanging file name even if the new serialisation code is disabled
by kill-switch.

Include code to migrate the file to the new naming scheme, and an unit
test checking the migration is happening as expected.

Bug: 1450598, 1383087, 1450598
Change-Id: Iea9793e8c00eb812f5f90fecdb3af69e2a7cde5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4628255
Reviewed-by: Federica Germinario <fedegermi@google.com>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1161690}
3 files changed
tree: be3a5b7d668c5afb5cec7721e42c1338888e0c25
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.