Google Git
Sign in
chromium / chromium / src / 5195da89e1301dc5db6a99f246acea3c3cb9b51f
commit5195da89e1301dc5db6a99f246acea3c3cb9b51f[log] [tgz]
authorDarwin Yang <darwinyang@google.com>Wed May 28 20:48:07 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 28 20:48:07 2025
tree11c801da34cf4d733e8f7eec49c6d0da6639debc
parentf6772c9dc435cad2fb5593db13676853adcf48b4 [diff]
[spc][clank][refactor] Refactor and Create New SPC Components for Clank

Create a copy of the SPC components (Controller, View, Properties,
ViewBinder) to be used for SPC UX Refresh. Refactor the controller to
remove feature flag usage (the entirety of the new controller will be
behind a feature flag instead) and to move the bottom sheet content
view and observer implementations outside of the controller to decrease
the bloat on the controller as well as the unit tests.

In addition, new tests were added for all the components and there
should now be 100% unit test coverage for SPC.

Note that the components were also tested on-device by showing the
controller from ChromePaymentRequestService.

Transaction View: http://screen/7UkHPm493FpDZzn
Fallback View: http://screen/qNwRMVmrvRAPHBu

Bug: 417977623
Change-Id: I5d79546fa738cbd7ea32b3d8468c41fa3388da44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580280
Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
Commit-Queue: Darwin Yang <darwinyang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1466697}
16 files changed
tree: 11c801da34cf4d733e8f7eec49c6d0da6639debc
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.