Google Git
Sign in
chromium / chromium / src / 521a165cc86cf091072e4ed569b1dcdd78b92077
commit521a165cc86cf091072e4ed569b1dcdd78b92077[log] [tgz]
authorAli Juma <ajuma@chromium.org>Fri Sep 10 19:17:11 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 10 19:17:11 2021
tree94807cce540703e890b60d5e1943006f0394d698
parent23c061137baf83bad78bbfa40c30f1e46669f85c [diff]
[iOS] Fix PasswordSpecFetcher on ASan builds

When PasswordSpecFetcher receives data as NSData*, it uses the
underlying data as a const char* that is passed to
base::Base64Decode. However, this data is not null-terminated,
so Base64Decode will keep reading past the end of this array until
a null character happens to be reached. This causes
PasswordSpecFetcherTest.DefaultSpecInvalidFetch to fail on the
ios-asan bot.

This CL safely converts the received data into a StringPiece with
a specific size, fixing the ASan failure.

Bug: 1248514

Change-Id: I83d441d00f58b9ca8f53990c31ef448d7b602608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152561
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920320}
1 file changed
tree: 94807cce540703e890b60d5e1943006f0394d698
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.