Google Git
Sign in
chromium / chromium / src / 52445a4616e86c41eff2ca001ea844befdb5ff39
commit52445a4616e86c41eff2ca001ea844befdb5ff39[log] [tgz]
authorRune Lillesveen <futhark@chromium.org>Thu Feb 17 15:46:36 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 17 15:46:36 2022
tree243ee7947a2d7209812b0c0db053229abb1ef0c1
parent511425ef3def9173bf6d1d811229efa9d61fe148 [diff]
Make sure we have consistent ComputedStyle flat trees

An element in the flat tree should never have a ComputedStyle if the
flat tree parent does not have one. When doing slot re-assignments we
could end up having ComputedStyle on a host child which was moved from a
slot which was part of the rendered flat tree into a slot that was
either in a display:none subtree or even outside the flat tree because
of another host ancestor without a slot in its shadow tree.

Make sure we clear the ComputedStyle, detach the layout tree, and clear
dirty bits in such cases.

Bug: 1282460
Change-Id: I8c3280f7ee580d6197ce8f5507150177639143d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468706
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#972454}
2 files changed
tree: 243ee7947a2d7209812b0c0db053229abb1ef0c1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.