commit 525c1520388c1a0aad6a7b82bbfc03eba7b35087
author Samuel Huang <huangs@chromium.org> Fri Jun 07 21:38:10 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 07 21:38:10 2024
tree dbf208c3ac9b17447bb44d0fd8d17a73bbaecb20
parent 1b752fec6138c5af59294d8b0197067164014981

[Android TRM] Promote V2 Provider to substitute Mixed Provider.

Prior to V2, the Tab Resumption Module uses 3 data providers to generate
suggestions:
  1a. Sync-Derived using Source whose backend is ForeignSessionHelper.
   2. Local-Tab (most recent): For Start-triggered NTP only.
   3. Mixed: Combines results from (1) and (2) to.

When we first integrated V2 suggestions (Fetch and Rank service), we
went with a "stopgap measure" by replacing (1a) with

  1b. Sync-Derived using Source whose backend is Visited Url Ranking
      (which uses JNI).

This allows delay handling and integration with (2) and (3).

Now that V2 suggestions also suggests Local Tabs, one issue that arose
is that Start-triggered NTP gets duplicated (crbug.com/345784944).

This CL fixes the issue and eases the stopgap measure by "promoting"
V2 Provider by replacing (3) instead of (1a) where applicable. Thus now
we have the following cases:
  * V2 full: Uses (1b).
  * V2 without Local Tabs: Use (1b)+(2)+(3)
  * V1: Use (1a)+(2)+(3).

Note that with V2 full, Local Tab suggestions can appear on all NTP, and
not just Start-triggered ones. Also, we still need to resolve the edge
case crbug.com/343095625.

Bug: 345784944, 337858147
Low-Coverage-Reason: Tests for the Builder is TODO (crbug.com/345809398).
Change-Id: Ie8fd3863393efc23f647a434b3b62b7fb871ac6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5607831
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1312265}