| commit | 52aa86a5f534672acb4e767579c317ebb1ab3517 | [log] [tgz] |
|---|---|---|
| author | YuhanYang <yyhyyh@google.com> | Wed Nov 29 19:04:33 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 29 19:04:33 2023 |
| tree | 7f165eaba6b61af4c3fef75a644cf540f51688aa | |
| parent | 6d1ea1258d03fbb98d3c3b1cfb6a60a38361b720 [diff] |
customization: Fix modifier key duplicating bug When only pressing a single modifier key in the key combination dialog, the label sometimes displays as shift + shift instead of a single shift. Temporarily avoid this case with a simple fix until it's fixed in the shortcut acceleration logics. Screenshot: Before: https://screenshot.googleplex.com/94Sy2WJz4Ai9EQD After: https://screenshot.googleplex.com/5hrESyGuGvQ4NwB Bug: b/241965717 Test: browser_tests Change-Id: I34f5bcde5daf38bba8f3a7fffeade26df13e9120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5068083 Commit-Queue: Yuhan Yang <yyhyyh@google.com> Reviewed-by: Danny Wang <wangdanny@google.com> Cr-Commit-Position: refs/heads/main@{#1230802}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.