commit | 52ba50b25ccb6f4d282eea2df153368887ff9250 | [log] [tgz] |
---|---|---|
author | Sky Malice <skym@chromium.org> | Fri Oct 16 22:47:07 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 16 22:47:07 2020 |
tree | b6ba04968b4223623c8beb0003194d938d38fbe7 | |
parent | 3bff4f7264daa7e1018ce73a6d14a33dd26536b0 [diff] |
Revert "network: de-flake NetworkQualityEstimator throttling test" This reverts commit 342a65b727103bfd7d53cd02a8d66544130ae3b0. Reason for revert: Test failure https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2559 Original change's description: > network: de-flake NetworkQualityEstimator throttling test > > This test has is flaky when run on devices that have a real wifi or > cellular connection, because in that situation, the call to > SimulateNetworkChange() can cause an arbitrary number of real calls > to GetCurrentSignalStrengthWithThrottling(). This change de-flakes > the test in that situation by: > > 1) Delaying constructing the HistogramTester, to avoid counting > those calls, and > 2) Advancing the fake time the test uses at the start of the test, > so that the NetworkQualityEstimator under test is never in its > timeout period when the test starts > > This change also re-enables the test on Android, since this should > de-flake the test there too. > > Bug: 1133439,1130720 > Change-Id: I4164ce4bb105082fe58382c3f7c72b5b9462a8ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476812 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817719} TBR=ellyjones@chromium.org,tbansal@chromium.org Change-Id: Id4bd9253500cd585a1ce38fd49b5fcae6db7c555 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133439 Bug: 1130720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482084 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818142}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.