commit 52bb258da91b9687e603db9a547b671be4189784
author Leonard Grey <lgrey@chromium.org> Thu Jan 26 22:10:09 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 26 22:10:09 2023
tree c9f05ba12ac135ec92ffb0969e0c8d6f73a35ed6
parent 6f1e93b5421832b54ffbf2d5b35b93ccb8423bbd

Revert "Drop psm::FakeRlweClient"

This reverts commit b53d2867c3db9e63534ef989afaa422d87958eb5.

Reason for revert: Several enterprise.ARCBoot* tests on chromeos-eve-chrome and chromeos-kevin-chrome hitting a CHECK added in this CL:
2023-01-26T18:02:42.855391Z FATAL fake_dmserver: [request_handler_for_psm_auto_enrollment.cc(72)] Check failed: base::PathExists(path_to_test_data).  path_to_test_data: /usr/local/third_party/private_membership/src/internal/testing/regression_test_data/test_data.binarypb

First failures:
https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-eve-chrome/25532/overview
https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-kevin-chrome/26204

Original change's description:
> Drop psm::FakeRlweClient
>
> FakeRlweClient is anything but simple. It partially reimplements the
> PIR logic from the
> private_membership::rlwe::PrivateMembershipRlweClient, which forces
> the policy::RequestHandlerForPsmAutoEnrollment to reply with
> corresponding data. However, all of this should be implementation
> details of the PSM library. It contradicts the general idea that
> tests should be easy to understand.
>
> This change drops the FakeRlweClient and the
> RequestHandlerForPsmAutoEnrollment.
>
> Instead, tests can now use psm::RlweTestSupport to construct an
> RlweClientImpl from a test case from the PSM library's test database.
> The EmbeddedPolicyTestServer is also using the test cases from the
> test database to validate requests and send appropriate responses.
>
> This makes the test logic less complex, requiring less understanding
> of implementation details.
>
> Bug: b/241911665
> Change-Id: Ifae396257638433503ff82e19945e62d38df60c1
> Tests: Refactored browser tests
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4155468
> Reviewed-by: Danila Kuzmin <dkuzmin@google.com>
> Commit-Queue: Roland Bock <rbock@google.com>
> Reviewed-by: Igor <igorcov@chromium.org>
> Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1097319}

Bug: b/241911665
Change-Id: I64376ad03f981a886b36657c2681a0a8ef6bcb12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198898
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1097628}