commit | 52f44d61027a768ba7ad140e437229d20d3294c7 | [log] [tgz] |
---|---|---|
author | Rune Lillesveen <futhark@google.com> | Thu Aug 05 09:23:06 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 05 09:23:06 2021 |
tree | 91285db7bfe0e05f800e941a7fc03d1a1be70f2f | |
parent | 8cf17a3f5b37e59b60dcb542ec334de803c9d643 [diff] |
Revert "CCA: Better CSS extern types for closure compiler" This reverts commit 0f4339162b7f0dbdb5fa48cfd8f3287788a86aa6. Reason for revert: suspected to cause crbug.com/1236947 Original change's description: > CCA: Better CSS extern types for closure compiler > > The current closure compiler extern types for CSS Typed OM Level 1 has > some incorrect types according to spec [1]. Fix the types. > > This also fix a bug that document_corner_overlay use incorrect unit > (rotation in deg instead of rad). > > This drops the error of `cca.py tsc` from 92 to 88 if we patched in > @types/w3c-css-typed-object-model-level-1. Unfortunately the error count > increases from 119 to 121 without the type definition because of the > missing types. All the CSSOM types for TypeScript will be addressed in > the later CL. > > [1]: https://drafts.css-houdini.org/css-typed-om > > Bug: b:172340451 > Test: cca.py tsc > Test: closure compiler passes > Test: tast run <ip> camera.CCAUISmoke* camera.CCAUIStress* > Change-Id: I805c82a971e5e4becf9f71d62592a8dffaa27dea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3070719 > Reviewed-by: Shik Chen <shik@chromium.org> > Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#908774} Bug: b:172340451 Change-Id: I0d700e9d8e369cbe86297c6cf0352fb6d8ff064c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074281 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rune Lillesveen <futhark@google.com> Owners-Override: Rune Lillesveen <futhark@google.com> Cr-Commit-Position: refs/heads/master@{#908806}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.