| commit | 53310093e52793d5a0e10227343214848458caea | [log] [tgz] |
|---|---|---|
| author | Frank Liberato <liberato@chromium.org> | Thu Feb 01 23:32:00 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 01 23:32:00 2024 |
| tree | 696494d3dabfb641159ee2f51339dcb83d93ccfe | |
| parent | 6a86a5d32e99c023acc30ccbb552ecff1c372a3c [diff] |
[pip] Enforce maximum size >= minimum size for document pip This is a speculative fix for a dcheck that shows up on CrOS. A window resize operation fails because the max size is smaller than the min size. The only path that looks like this might happen is if there's no native window when the max size is computed -- it'll return (0, 0) instead. While this sometimes means "unlimited", the resizing code interprets it as (0, 0). Since "unlimited" is probably not the right thing for the pip window, we just limit it to the min size. Bug: 1454304 Change-Id: I1584fceb54c3651698464c1e0bc82b36c1fbec65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259159 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255344}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.