Google Git
Sign in
chromium / chromium / src / 534017fd862e259b25f0e90eed70a44345e1b7ca
commit534017fd862e259b25f0e90eed70a44345e1b7ca[log] [tgz]
authorWenbo Jie <wenbojie@chromium.org>Sun Feb 20 23:11:47 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Feb 20 23:11:47 2022
tree6d9646c2804082ed30a38b5fbca9d5df5a4e3d76
parent43c789f9e7cb8c1274df712506364c38c870ee72 [diff]
[FilesA11y] Keep focus on "switch view" button after it's activated

When "switch view" button is activated by keyboard, the focus should
stay on the button to keep consistent behaviour as other action buttons.

Note: there are also other changes in the CL
* Add a public method for FilesTooltip called showTooltip(), it will
explicitly show tooltip for the current visible tooltip target.
* Handle keyup/click event together to prevent infinite triggering for
callback. "click" event will be triggered multiple times if users hold
Enter/Space key down without releasing (demo: http://shortn/_Z1x7Cq1SfF),
we need to have additional logic there to prevent it (demo:
http://shortn/_QzY2THz20b)

Demo: http://shortn/_NzAKaQfuHo

Bug: 1221202
Test: deployed to DUT and visually inspect
Test: browser_tests --gtest_filter="*FilesTooltip*"
Change-Id: Ib1ab52ee7c54f253731611934d77163dc2df235b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3459366
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Wenbo Jie <wenbojie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973389}
7 files changed
tree: 6d9646c2804082ed30a38b5fbca9d5df5a4e3d76
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.