Google Git
Sign in
chromium / chromium / src / 53caa83e254f03a5d0346ad9e2f5211ed65922a7
commit53caa83e254f03a5d0346ad9e2f5211ed65922a7[log] [tgz]
authorMaksim Ivanov <emaxx@chromium.org>Wed Feb 09 16:33:25 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 09 16:33:25 2022
tree120b8f1399dec6e64cdf2e160e1a4e4b14e19b81
parent1a0e89b0e001c5951abeb47e90c99f2233a49780 [diff]
Finish security token SAML tests with closeView

Update the mixin used for security token SAML tests (a.k.a. smart card
based login) to load the fake Gaia page that notifies Chrome with
userInfo and closeView messages. This should speed up the browser tests
by letting them not rely on the Gaia flow timeout.

Part of the fix in this commit is to send the RelayState parameter from
the fake SAML page to the fake Gaia via a POST request - previously we
were doing it via GET, which neither was understood by fake Gaia nor
corresponds to real-world SAML deployments.

Also delete a useless line in the
saml_api_login_auth_without_confirm.html test page.

Bug: 1207833
Test: cherry-pick crrev.com/c/3025668 and check SecurityTokenSamlTest.Basic still passes
Change-Id: I82506ef794c655c8e2ebe61b2aa7bc38f1526acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449252
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968952}
7 files changed
tree: 120b8f1399dec6e64cdf2e160e1a4e4b14e19b81
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.