Spanification tool improvement

When rewriting C-style arrays to std::arrays, we sometimes need to add
extra braces around the initializer_list. This was handled by including
the entire intializer_list in the replacement text and which led to the
need to escape special characters in the replacement.

This change introduces the `additional_replacement` field used to split
some nodes into two. Splitting some replacements into two allows to
combine multiple changes without causing a replacement overlap. Indeed,
being able to submit two changes instead of one would avoid replacing a
large content of text shared by multiple changes.

For instance:
*(iterator++)
needs to two changes:
*(base::postIncrementSpan(iterator))
and then
base::postIncrementSpan(iterator)[0]

Using the `additional_replacement`, this change splits C-style array
rewrite nodes into two nodes where necessary. This removes the need to
escape initializer_list characters.

The first node contains the replacement directive for the array type and
the opening extra brace '{' (if any), the second node (marked as
dependent on the first) contains the trailing closing brace '}' (if
any).

Change-Id: Ib0addca44e4bcdb367e422cf50a2a3ca2dba0d09
Bug: 356643982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6177729
Commit-Queue: Ali Hijazi <ahijazi@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409603}
2 files changed
tree: 1d9b1abed36bab42bbeb687992f3def68720b549
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. description
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.